Improved install routine #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed install folder to follow xdg specification Changed temp and working folders in order to avoid user data deletion
the-phinet
commented
Aug 27, 2025
mak448a
reviewed
Aug 27, 2025
| INSTALL_DIR="${XDG_DATA_HOME}/aseprite" | ||
| BINARY_DIR="${HOME}/.local/bin" | ||
| LAUNCHER_DIR="${XDG_DATA_HOME}/applications" | ||
| ICON_DIR="${XDG_DATA_HOME}/icons" |
There was a problem hiding this comment.
Don't we need to put this into hicolor to get it to work? I'm currently compiling Aseprite with your version so I wouldn't know lol
There was a problem hiding this comment.
Yes, I believe you are correct.
While it seems to be working on my end, we should probably move it to "${XDG_DATA_HOME}/icons/hicolor/256x256/apps"
When I get a chance, I'll check what icons aseprite distributes, other than the 256 version
Edit: It works on my pc, because my icon theme (papyrus) comes with an aseprite icon
Edit 2: Yeah, they distribute other sizes, too. I'll fix the script in a bit
There was a problem hiding this comment.
It also seems to be working on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit set contains a number of fixes and changes. I can split them into multiple pull requests if you'd like
Fixes:
Changes: